make NodeTraverser public and improves it with preOder/postOrder methods #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This includes making some parts of the general Traverser public, but not everything. |
Member
Author
|
@bbakerman @gkesler @exbe I would like to link to some good explanation about general traversal and for example pre/post order is a special case of depthFirst. Any recommendations? thx |
bbakerman
approved these changes
Jun 24, 2018
Member
bbakerman
left a comment
bbakerman
left a comment
There was a problem hiding this comment.
Looks good to me - nothing stands out as a problem
Contributor
|
@andimarek Are you looking for an example, explanation or something else? Updated: I think it make sense to add similar special cases for breadthFirst too as a legitimate api. |
andimarek
force-pushed
the
node-traverser
branch
from
0fa461d to
359880d
Compare
exbe
pushed a commit
to intuit/graphql-java
that referenced
this pull request
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-java should provide a good way to traverse a Document/Query. This makes the NodeTraverser public and adds special pre/post Order methods for easy usage.