Consolidates the isNonNull and isList for consistency and readability#1095
Merged
bbakerman merged 3 commits intoJun 24, 2018
Merged
Conversation
andimarek
requested changes
Jun 22, 2018
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import static graphql.schema.GraphQLTypeUtil.*; |
Member
There was a problem hiding this comment.
I think your formatter settings is not correct :-)
See: https://github.com/graphql-java/graphql-java/blob/master/graphql-java-code-style.xml
Member
|
|
…til-where-we-can # Conflicts: # src/main/java/graphql/schema/idl/SchemaGeneratorHelper.java # src/main/java/graphql/validation/rules/VariablesTypesMatcher.java
Member
Author
|
Actually I moved the isLeaf and isInput methods out of SchemaUtil and then its NO longer used by any code Its @internal and hence we can kill it I will do that in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the very common pattern of instanceof X, cast to X and unwrap more readable