Skip to content

Test using other JDK versions? #3367

Closed
Closed

Description

@yeikel

Hi all,

I noticed that the project is configured to test using Java 11

Would you support building and testing (no need to release) using other versions?

In particular, it would be ideal to check that the project works as expected with at least the newer LTS versions (17,21 at the time of this writing), and possibly with the latest Java version if possible (22)

I am open to send a PR with the same if accepted

Thanks!

Activity

  1. dondonz commented on Oct 26, 2023

    @dondonz
    Member

    We do have a PR up from @jord1e with something along the same lines - would their PR meet your requirements?

    #2789

    It is on me to review that PR

  2. yeikel commented on Oct 27, 2023

    @yeikel
    ContributorAuthor

    We do have a PR up from @jord1e with something along the same lines - would their PR meet your requirements?

    #2789

    It is on me to review that PR

    That one appears to be considerably more advanced than the specific request I have made (which might explain why it's still under review).

    My request, in contrast, is quite straightforward: I'd like to update the CI to run tests against different Java versions which should not involve(at least in theory) changes to the build or other files

    if you think that #2789 will be reviewed soon, then we can close this one. Otherwise, we might be able to have a small win implementing this issue in the meantime

  3. reopened this on Oct 27, 2023
  4. jord1e commented on Oct 27, 2023

    @jord1e
    Contributor

    I updated #2789 and I think we can close this as a duplicate of #2676 (?), please comment on the PR if you have more suggestions

  5. yeikel commented on Oct 28, 2023

    @yeikel
    ContributorAuthor

    That's fair. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions