Skip to content

Upgrade to SLF4J 2.0.x - Is that needed #3339

Closed

Description

@schaefa

With Sling GraphQL Core I am running into an issue when upgrading to 21.x that the project upgraded to SLF4J 2.0.7 but that breaks our integration.

When I downgrade graphql-java to SLF4J to 1.7.25 and build it with the latest code (aka fixing the android.os issue) it compiles and works just fine.

If GraphQL-Java works with SLF4J 1.7.25 why did you upgrade as I am pretty sure not the only one that might have dependency issues.

Activity

  1. schaefa commented on Sep 28, 2023

    @schaefa
    ContributorAuthor

    I don't mind the upgrade but maybe the release could ask for a range in MANIFEST.MF that includes 1.7 as lower end (or even lower) instead of 2.0.

  2. dondonz commented on Sep 29, 2023

    @dondonz
    Member

    Hello, thanks for reporting the issue!

    As more background, we automatically update dependencies with Dependabot. There wasn't any particular reason for upgrading from that version of SLF4J.

    I'll have a closer look and think about what we can do, there are a few options.

  3. schaefa commented on Sep 29, 2023

    @schaefa
    ContributorAuthor

    Changing this in build.gradle seems to do the trick:
    Import-Package: !android.os.,!com.google.,!org.checkerframework.,!javax.annotation.,!graphql.com.google.,!org.antlr.,!graphql.org.antlr.,!sun.misc.,org.slf4j;version="[1.7,3.0)",*

  4. dondonz commented on Oct 10, 2023

    @dondonz
    Member

    Another option I'll have a look at is removing SLF4J entirely. We don't use it in many places.

    Thanks for raising the issue which gives me extra motivation to get this done!

  5. added
    keep-openTells Stale Bot to keep PRs and issues open
    on Dec 5, 2023
  6. dondonz commented on Jan 29, 2024

    @dondonz
    Member

    From the next release, we'll be removing SLF4J as a dependency entirely #3403

    Thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    keep-openTells Stale Bot to keep PRs and issues open

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions