Skip to content

antlr4 v4.10.x is out - any plans to use / adopt to it? #2809

Closed

Description

@aamotharald

Are there any pland to move to antlr 4.10.x ?
This implies re-generating the scanners, lexers and parsers based on a grammar. 4.9.x (compile-time) and 4.10.x (runtime) does not work.
It's just a technicality to upgrade, but it has to be done in one step.

Activity

  1. andimarek commented on Apr 22, 2022

    @andimarek
    Member

    We don't have specific plans, but we are open for a pull request if you would like to contribute.

    Is there a specific reason that you ask?

    Thanks!

  2. aamotharald commented on Apr 22, 2022

    @aamotharald
    Author

    Hi @andimarek ,
    there is no specific reason. My project uses the renovate bot that informed us about the new antlr4 version with a PR.
    We noticed that we can only move to this version when all other (reuse)libraries that use antlr4 are also on that version. So graphql-java is one of these. It's a bigger coordination effort for us to move to antlr4 v 4.10.x and would have rather expected this to be version 5.x.x . In other words: if I start a contribution for graphql-java a major version bump should be considered to not cause runtime issues by your consumers. I am still not sure how I should deal with this, but I am happy to make a contribution there if the question about the semantic versioning for graphql-java would be discussed out..

  3. dondonz commented on Jun 14, 2022

    @dondonz
    Member

    Thanks for raising the issue! We're now shading antlr-runtime, which will resolve this version clash problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions