Skip to content

guava 30 dependency is removed from pom, but not from gradle metadata #2728

Closed

Description

@mmorrisontx

Describe the bug
From what I understand, guava 30 is purposefully being shadowed and relocated into graphql-java. This seems to be reflected properly in the graphql-java pom, which properly does not have a guava dependency. Unfortunately, it is not reflected in the gradle library metadata, where the guava dependency is still present: https://repo1.maven.org/maven2/com/graphql-java/graphql-java/17.3/graphql-java-17.3.module

This means that maven consumers properly do not receive guava 30 through graphql-java, but gradle consumers improperly do receive the gradle 30 dependency.

Activity

  1. dondonz commented on Feb 17, 2022

    @dondonz
    Member

    Hello! Yes that's spot on.

    This PR resolved the issue, which was merged into master. It will be included in the next release. #2586

  2. mmorrisontx commented on Feb 17, 2022

    @mmorrisontx
    Author

    If you are interested in restoring gradle metadata in the future, I believe if you use these instructions (using the shadow publication, and moving 'exposed' dependencies to the shadow configuration), the shadowjar plugin will properly manage both the pom and the gradle metadata for you.

  3. andimarek commented on Apr 26, 2022

    @andimarek
    Member

    This fix is released in 18.0. If you want to have gradle metata please open a new issue. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions