You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
graphql.schema.DataFetchingEnvironment can be an interface #260
Tells a maintainer what they need to know. It must return a FooObject and hence so must the method call etc..
In fact this could be applied to a number of places in GraphQL Java. I think I may raise another issue to cover this specifically rather than hijack this isssue
Activity
dminkovsky commentedon Dec 9, 2016
That sounds good to me. Thank you!
bbakerman commentedon Dec 11, 2016
Can I make another suggestion... it should generic as well.
With no generics we have the above. The ACTUAL return type is Object so its hard to maintain. But the shape of fetched objects are really important.
Where as
Tells a maintainer what they need to know. It must return a FooObject and hence so must the method call etc..
In fact this could be applied to a number of places in GraphQL Java. I think I may raise another issue to cover this specifically rather than hijack this isssue
jimexist commentedon Dec 12, 2016
@bbakerman i agree with you but i would go ahead and make my PR smaller - maybe your idea is better implemented in another PR.
dminkovsky commentedon Jan 18, 2017
Fixed in #301. Thank you @jimexist!