You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make SimpleDataFetcherExceptionHandler error logging configurable/overridable (or remove) #2564
With the latest versions, SimpleDataFetcherExceptionHandler both handles and returns failure information (makes sense) and also always logs it as an error (which to me does not usually make sense, although I can see how some might want that).
Further, failure is logged along with exception with result of lots of log noise for most cases where exception message along is sufficient and origins of exception are of no interest, for us least.
I know that it is possible to configure logging to try to remove this output (although it being at WARN level, it is also bit awkward conceptually). But since this is a handler it seems like ability to either configure behavior, or, perhaps, just overridability, would suffice.
So the simplest change would be to extract line:
Doing this would allow developers to override the default implementation and change handling wrt logging level, inclusion of information; or even just not logging at all (since it will be further handled at higher levels anyway).
Activity
https://github.com/graphql-java/graphql-java/issues/2564
#2564 (#2569)
tatu-at-datastax commentedon Oct 4, 2021
Thank you @bbakerman !