Skip to content

FetchedValue can't be internal #2116

Closed
Closed

Description

@andimarek

InstrumentationFieldCompleteParameters.fetchedValue is actually FetchedValue and not Object. We should make it clear and therefore make FetchedValue public API.

Activity

  1. bbakerman commented on Jul 14, 2021

    @bbakerman
    Member

    actually its not quite true

        protected FieldValueInfo completeValueForList(ExecutionContext executionContext, ExecutionStrategyParameters parameters, Iterable<Object> iterableValues) {
    
            OptionalInt size = FpKit.toSize(iterableValues);
            ExecutionStepInfo executionStepInfo = parameters.getExecutionStepInfo();
    
            InstrumentationFieldCompleteParameters instrumentationParams = new InstrumentationFieldCompleteParameters(executionContext, parameters, () -> executionStepInfo, iterableValues);
    
    
    

    In this case we have an iterable of values

  2. andimarek commented on Jan 26, 2022

    @andimarek
    MemberAuthor

    Addressed by #2690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions