Skip to content

Type serialization/coercion not according to the spec #171

Closed

Description

@drkarl

This commit titled as a bugfix is actually introducing a bug since now is no longer according to the spec:

43d5f57

The spec says:

https://facebook.github.io/graphql/#sec-Coercing-Variable-Values

If the operation has defined any variables, then the values for those variables need to be coerced using the input coercion rules of variable’s declared type. If a query error is encountered during input coercion of variable values, then the operation fails without execution.

Also

https://facebook.github.io/graphql/#sec-Scalars

A GraphQL server, when preparing a field of a given scalar type, must uphold the contract the scalar type describes, either by coercing the value or producing an error.

For example, a GraphQL server could be preparing a field with the scalar type Int and encounter a floating‐point number. Since the server must not break the contract by yielding a non‐integer, the server should truncate the fractional value and only yield the integer value. If the server encountered a boolean true value, it should return 1. If the server encountered a string, it may attempt to parse the string for a base‐10 integer value. If the server encounters some value that cannot be reasonably coerced to an Int, then it must raise a field error.

Activity

  1. added this to the milestone on May 20, 2017
  2. andimarek commented on May 23, 2017

    @andimarek
    Member

    This is fixed with #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions