Skip to content

InstrumentationContext onDispatched not called for parsing #1620

@Keisuki

Description

@Keisuki

Describe the bug
For a couple of the methods on Instrumentation (beginParse and beginValidation) the onDispatched method on the returned InstrumentationContext is not called.

To Reproduce
My Instrumentation, which is later passed into a GraphQL instance:

public class TestInstrumentation extends SimpleInstrumentation {
  @Override
  public InstrumentationContext<Document> beginParse(InstrumentationExecutionParameters parameters) {
    return new InstrumentationContext<>() {
      @Override
      public void onDispatched(CompletableFuture<Document> result) {
        System.out.println("Dispatched");
      }

      @Override
      public void onCompleted(Document result, Throwable t) {
        System.out.println("Completed");
      }
    };
  }
}

Expected:

Dispatched
Completed

Actual:

Completed

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions