Skip to content

Commit fe1ac76

Browse files
dondonzdondonz
committed
Merge branch 'master' into make-strict-runtime-wiring-default
2 parents e0b2c27 + 8aa04f6 commit fe1ac76

153 files changed

Lines changed: 23487 additions & 597 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,6 @@ take the time to read it.
3232
### License
3333

3434
Copyright (c) 2015, Andreas Marek and [Contributors](https://github.com/graphql-java/graphql-java/graphs/contributors)
35+
36+
### Powered by
37+
[![IntelliJ IDEA logo](https://resources.jetbrains.com/storage/products/company/brand/logos/IntelliJ_IDEA.svg)](https://jb.gg/OpenSourceSupport)

‎agent-test/build.gradle‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ plugins {
44

55
dependencies {
66
implementation(rootProject)
7-
implementation("net.bytebuddy:byte-buddy-agent:1.17.0")
7+
implementation("net.bytebuddy:byte-buddy-agent:1.17.2")
88

9-
testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
9+
testImplementation 'org.junit.jupiter:junit-jupiter:5.12.0'
1010
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
1111

1212
testImplementation("org.assertj:assertj-core:3.27.3")

‎agent/build.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ plugins {
66
}
77

88
dependencies {
9-
implementation("net.bytebuddy:byte-buddy:1.17.0")
9+
implementation("net.bytebuddy:byte-buddy:1.17.2")
1010
// graphql-java itself
1111
implementation(rootProject)
1212
}

‎agent/src/main/java/graphql/agent/GraphQLJavaAgent.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public static void agentmain(String agentArgs, Instrumentation inst) {
7171
return builder
7272
.visit(Advice.to(DataLoaderHelperDispatchAdvice.class).on(nameMatches("dispatch")))
7373
.visit(Advice.to(DataLoaderHelperInvokeBatchLoaderAdvice.class)
74-
.on(nameMatches("invokeLoader").and(takesArguments(List.class, List.class))));
74+
.on(nameMatches("invokeLoader").and(takesArguments(List.class, List.class, List.class))));
7575
})
7676
.type(named("graphql.schema.DataFetchingEnvironmentImpl"))
7777
.transform((builder, typeDescription, classLoader, module, protectionDomain) -> {
@@ -207,6 +207,7 @@ public static class DataLoaderHelperInvokeBatchLoaderAdvice {
207207
@Advice.OnMethodEnter
208208
public static void invokeLoader(@Advice.Argument(0) List keys,
209209
@Advice.Argument(1) List keysContext,
210+
@Advice.Argument(2) List queuedFutures,
210211
@Advice.This(typing = Assigner.Typing.DYNAMIC) Object dataLoaderHelper) {
211212
DataLoader dataLoader = getDataLoaderForHelper(dataLoaderHelper);
212213
ExecutionId executionId = GraphQLJavaAgent.dataLoaderToExecutionId.get(dataLoader);

‎build.gradle‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,27 +99,27 @@ jar {
9999
}
100100

101101
dependencies {
102-
compileOnly 'org.jetbrains:annotations:26.0.2'
103102
implementation 'org.antlr:antlr4-runtime:' + antlrVersion
104-
api 'com.graphql-java:java-dataloader:3.3.0'
103+
api 'com.graphql-java:java-dataloader:3.4.0'
105104
api 'org.reactivestreams:reactive-streams:' + reactiveStreamsVersion
105+
api "org.jspecify:jspecify:1.0.0"
106106
antlr 'org.antlr:antlr4:' + antlrVersion
107107
implementation 'com.google.guava:guava:' + guavaVersion
108108
testImplementation group: 'junit', name: 'junit', version: '4.13.2'
109109
testImplementation 'org.spockframework:spock-core:2.0-groovy-3.0'
110-
testImplementation 'org.codehaus.groovy:groovy:3.0.23'
111-
testImplementation 'org.codehaus.groovy:groovy-json:3.0.23'
110+
testImplementation 'org.codehaus.groovy:groovy:3.0.24'
111+
testImplementation 'org.codehaus.groovy:groovy-json:3.0.24'
112112
testImplementation 'com.google.code.gson:gson:2.12.1'
113113
testImplementation 'org.eclipse.jetty:jetty-server:11.0.24'
114-
testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.18.2'
114+
testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.18.3'
115115
testImplementation 'org.awaitility:awaitility-groovy:4.2.0'
116116
testImplementation 'com.github.javafaker:javafaker:1.0.2'
117117

118118
testImplementation 'org.reactivestreams:reactive-streams-tck:' + reactiveStreamsVersion
119119
testImplementation "io.reactivex.rxjava2:rxjava:2.2.21"
120-
testImplementation "io.projectreactor:reactor-core:3.7.2"
120+
testImplementation "io.projectreactor:reactor-core:3.7.3"
121121

122-
testImplementation 'org.testng:testng:7.10.2' // use for reactive streams test inheritance
122+
testImplementation 'org.testng:testng:7.11.0' // use for reactive streams test inheritance
123123

124124
testImplementation 'org.openjdk.jmh:jmh-core:1.37'
125125
testAnnotationProcessor 'org.openjdk.jmh:jmh-generator-annprocess:1.37'

‎performance-results/2025-02-16T03:40:11Z-fc9c1336de7ab351d6cd6a68a43e8ee6b7876fb6-jdk17.json‎

Lines changed: 287 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,287 @@
1+
[
2+
{
3+
"jmhVersion" : "1.37",
4+
"benchmark" : "performance.ComplexQueryPerformance.benchMarkSimpleQueriesThroughput",
5+
"mode" : "thrpt",
6+
"threads" : 1,
7+
"forks" : 2,
8+
"jvm" : "/home/ec2-user/.sdkman/candidates/java/17.0.10-amzn/bin/java",
9+
"jvmArgs" : [
10+
],
11+
"jdkVersion" : "17.0.10",
12+
"vmName" : "OpenJDK 64-Bit Server VM",
13+
"vmVersion" : "17.0.10+7-LTS",
14+
"warmupIterations" : 2,
15+
"warmupTime" : "5 s",
16+
"warmupBatchSize" : 1,
17+
"measurementIterations" : 2,
18+
"measurementTime" : "10 s",
19+
"measurementBatchSize" : 1,
20+
"params" : {
21+
"howManyItems" : "5"
22+
},
23+
"primaryMetric" : {
24+
"score" : 3.4197378188044096,
25+
"scoreError" : 0.04262561676864909,
26+
"scoreConfidence" : [
27+
3.3771122020357605,
28+
3.462363435573059
29+
],
30+
"scorePercentiles" : {
31+
"0.0" : 3.4117117828701837,
32+
"50.0" : 3.4198156241090585,
33+
"90.0" : 3.4276082441293374,
34+
"95.0" : 3.4276082441293374,
35+
"99.0" : 3.4276082441293374,
36+
"99.9" : 3.4276082441293374,
37+
"99.99" : 3.4276082441293374,
38+
"99.999" : 3.4276082441293374,
39+
"99.9999" : 3.4276082441293374,
40+
"100.0" : 3.4276082441293374
41+
},
42+
"scoreUnit" : "ops/s",
43+
"rawData" : [
44+
[
45+
3.418372884463662,
46+
3.4276082441293374
47+
],
48+
[
49+
3.4117117828701837,
50+
3.421258363754455
51+
]
52+
]
53+
},
54+
"secondaryMetrics" : {
55+
}
56+
},
57+
{
58+
"jmhVersion" : "1.37",
59+
"benchmark" : "performance.ComplexQueryPerformance.benchMarkSimpleQueriesThroughput",
60+
"mode" : "thrpt",
61+
"threads" : 1,
62+
"forks" : 2,
63+
"jvm" : "/home/ec2-user/.sdkman/candidates/java/17.0.10-amzn/bin/java",
64+
"jvmArgs" : [
65+
],
66+
"jdkVersion" : "17.0.10",
67+
"vmName" : "OpenJDK 64-Bit Server VM",
68+
"vmVersion" : "17.0.10+7-LTS",
69+
"warmupIterations" : 2,
70+
"warmupTime" : "5 s",
71+
"warmupBatchSize" : 1,
72+
"measurementIterations" : 2,
73+
"measurementTime" : "10 s",
74+
"measurementBatchSize" : 1,
75+
"params" : {
76+
"howManyItems" : "10"
77+
},
78+
"primaryMetric" : {
79+
"score" : 1.726255760607202,
80+
"scoreError" : 0.0069887452082228844,
81+
"scoreConfidence" : [
82+
1.719267015398979,
83+
1.7332445058154249
84+
],
85+
"scorePercentiles" : {
86+
"0.0" : 1.724942047136417,
87+
"50.0" : 1.7262524899916596,
88+
"90.0" : 1.7275760153090716,
89+
"95.0" : 1.7275760153090716,
90+
"99.0" : 1.7275760153090716,
91+
"99.9" : 1.7275760153090716,
92+
"99.99" : 1.7275760153090716,
93+
"99.999" : 1.7275760153090716,
94+
"99.9999" : 1.7275760153090716,
95+
"100.0" : 1.7275760153090716
96+
},
97+
"scoreUnit" : "ops/s",
98+
"rawData" : [
99+
[
100+
1.7261109025806118,
101+
1.7263940774027073
102+
],
103+
[
104+
1.724942047136417,
105+
1.7275760153090716
106+
]
107+
]
108+
},
109+
"secondaryMetrics" : {
110+
}
111+
},
112+
{
113+
"jmhVersion" : "1.37",
114+
"benchmark" : "performance.ComplexQueryPerformance.benchMarkSimpleQueriesThroughput",
115+
"mode" : "thrpt",
116+
"threads" : 1,
117+
"forks" : 2,
118+
"jvm" : "/home/ec2-user/.sdkman/candidates/java/17.0.10-amzn/bin/java",
119+
"jvmArgs" : [
120+
],
121+
"jdkVersion" : "17.0.10",
122+
"vmName" : "OpenJDK 64-Bit Server VM",
123+
"vmVersion" : "17.0.10+7-LTS",
124+
"warmupIterations" : 2,
125+
"warmupTime" : "5 s",
126+
"warmupBatchSize" : 1,
127+
"measurementIterations" : 2,
128+
"measurementTime" : "10 s",
129+
"measurementBatchSize" : 1,
130+
"params" : {
131+
"howManyItems" : "20"
132+
},
133+
"primaryMetric" : {
134+
"score" : 0.8695008952141935,
135+
"scoreError" : 0.002839649770146112,
136+
"scoreConfidence" : [
137+
0.8666612454440474,
138+
0.8723405449843395
139+
],
140+
"scorePercentiles" : {
141+
"0.0" : 0.8688932944831845,
142+
"50.0" : 0.8695867203095606,
143+
"90.0" : 0.8699368457544682,
144+
"95.0" : 0.8699368457544682,
145+
"99.0" : 0.8699368457544682,
146+
"99.9" : 0.8699368457544682,
147+
"99.99" : 0.8699368457544682,
148+
"99.999" : 0.8699368457544682,
149+
"99.9999" : 0.8699368457544682,
150+
"100.0" : 0.8699368457544682
151+
},
152+
"scoreUnit" : "ops/s",
153+
"rawData" : [
154+
[
155+
0.8688932944831845,
156+
0.869534969252187
157+
],
158+
[
159+
0.8699368457544682,
160+
0.8696384713669342
161+
]
162+
]
163+
},
164+
"secondaryMetrics" : {
165+
}
166+
},
167+
{
168+
"jmhVersion" : "1.37",
169+
"benchmark" : "performance.OverlappingFieldValidationPerformance.overlappingFieldValidationThroughput",
170+
"mode" : "thrpt",
171+
"threads" : 1,
172+
"forks" : 3,
173+
"jvm" : "/home/ec2-user/.sdkman/candidates/java/17.0.10-amzn/bin/java",
174+
"jvmArgs" : [
175+
],
176+
"jdkVersion" : "17.0.10",
177+
"vmName" : "OpenJDK 64-Bit Server VM",
178+
"vmVersion" : "17.0.10+7-LTS",
179+
"warmupIterations" : 2,
180+
"warmupTime" : "5 s",
181+
"warmupBatchSize" : 1,
182+
"measurementIterations" : 3,
183+
"measurementTime" : "10 s",
184+
"measurementBatchSize" : 1,
185+
"primaryMetric" : {
186+
"score" : 44.79340737680421,
187+
"scoreError" : 1.1283373708302868,
188+
"scoreConfidence" : [
189+
43.665070005973924,
190+
45.9217447476345
191+
],
192+
"scorePercentiles" : {
193+
"0.0" : 44.22709764883389,
194+
"50.0" : 44.37852960081133,
195+
"90.0" : 45.72777210141981,
196+
"95.0" : 45.72777210141981,
197+
"99.0" : 45.72777210141981,
198+
"99.9" : 45.72777210141981,
199+
"99.99" : 45.72777210141981,
200+
"99.999" : 45.72777210141981,
201+
"99.9999" : 45.72777210141981,
202+
"100.0" : 45.72777210141981
203+
},
204+
"scoreUnit" : "ops/s",
205+
"rawData" : [
206+
[
207+
44.37103141816148,
208+
44.37808732974959,
209+
44.43775470829123
210+
],
211+
[
212+
45.68653293043291,
213+
45.63986315460877,
214+
45.72777210141981
215+
],
216+
[
217+
44.37852960081133,
218+
44.29399749892893,
219+
44.22709764883389
220+
]
221+
]
222+
},
223+
"secondaryMetrics" : {
224+
}
225+
},
226+
{
227+
"jmhVersion" : "1.37",
228+
"benchmark" : "performance.OverlappingFieldValidationPerformance.overlappingFieldValidationAbgTime",
229+
"mode" : "avgt",
230+
"threads" : 1,
231+
"forks" : 3,
232+
"jvm" : "/home/ec2-user/.sdkman/candidates/java/17.0.10-amzn/bin/java",
233+
"jvmArgs" : [
234+
],
235+
"jdkVersion" : "17.0.10",
236+
"vmName" : "OpenJDK 64-Bit Server VM",
237+
"vmVersion" : "17.0.10+7-LTS",
238+
"warmupIterations" : 2,
239+
"warmupTime" : "5 s",
240+
"warmupBatchSize" : 1,
241+
"measurementIterations" : 3,
242+
"measurementTime" : "10 s",
243+
"measurementBatchSize" : 1,
244+
"primaryMetric" : {
245+
"score" : 0.02254336100574041,
246+
"scoreError" : 0.0014251861750202459,
247+
"scoreConfidence" : [
248+
0.021118174830720163,
249+
0.023968547180760656
250+
],
251+
"scorePercentiles" : {
252+
"0.0" : 0.02140835029059829,
253+
"50.0" : 0.022582479492099322,
254+
"90.0" : 0.023531701548235293,
255+
"95.0" : 0.023531701548235293,
256+
"99.0" : 0.023531701548235293,
257+
"99.9" : 0.023531701548235293,
258+
"99.99" : 0.023531701548235293,
259+
"99.999" : 0.023531701548235293,
260+
"99.9999" : 0.023531701548235293,
261+
"100.0" : 0.023531701548235293
262+
},
263+
"scoreUnit" : "s/op",
264+
"rawData" : [
265+
[
266+
0.023531701548235293,
267+
0.02344455574941452,
268+
0.023488433495305164
269+
],
270+
[
271+
0.021671676398268398,
272+
0.02140835029059829,
273+
0.021538914713978494
274+
],
275+
[
276+
0.022566439108108106,
277+
0.022657698255656108,
278+
0.022582479492099322
279+
]
280+
]
281+
},
282+
"secondaryMetrics" : {
283+
}
284+
}
285+
]
286+
287+

0 commit comments

Comments
 (0)