Update test for Argument, and make nonnullable field clearer

dondonz · dondonz · commit 71ef68045ff0 · 2025-08-31T20:24:16.000+02:00
diff --git a/src/main/java/graphql/language/Argument.java b/src/main/java/graphql/language/Argument.java
@@ -32,7 +32,7 @@ public class Argument extends AbstractNode<Argument> implements NamedNode<Argume
     @Internal
     protected Argument(String name, Value value, @Nullable SourceLocation sourceLocation, List<Comment> comments, IgnoredChars ignoredChars, Map<String, String> additionalData) {
         super(sourceLocation, comments, ignoredChars, additionalData);
-        this.name = name;
+        this.name = assertNotNull(name, () -> "Argument name cannot be null");
         this.value = assertNotNull(value, () -> "Argument value cannot be null");
     }
 
@@ -99,7 +99,7 @@ public boolean isEqualTo(@Nullable Node o) {
 
     @Override
     public Argument deepCopy() {
-        return new Argument(name, assertNotNull(deepCopy(value), "Argument value cannot be null"), getSourceLocation(), getComments(), getIgnoredChars(), getAdditionalData());
+        return new Argument(assertNotNull(name, "Argument name cannot be null"), assertNotNull(deepCopy(value), "Argument value cannot be null"), getSourceLocation(), getComments(), getIgnoredChars(), getAdditionalData());
     }
 
     @Override
diff --git a/src/test/groovy/graphql/language/NodeVisitorStubTest.groovy b/src/test/groovy/graphql/language/NodeVisitorStubTest.groovy
@@ -132,7 +132,7 @@ class NodeVisitorStubTest extends Specification {
 
         where:
         node                                                         | visitMethod
-        new Argument("", null)                                       | 'visitArgument'
+        new Argument("myArgument", NullValue.of())                   | 'visitArgument'
         new Directive("", emptyList())                               | 'visitDirective'
         new DirectiveLocation("")                                    | 'visitDirectiveLocation'
         Document.newDocument().build()                               | 'visitDocument'

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public class Argument extends AbstractNode<Argument> implements NamedNode<Argume`
`32`	`32`	`@Internal`
`33`	`33`	`protected Argument(String name, Value value, @Nullable SourceLocation sourceLocation, List<Comment> comments, IgnoredChars ignoredChars, Map<String, String> additionalData) {`
`34`	`34`	`super(sourceLocation, comments, ignoredChars, additionalData);`
`35`		`- this.name = name;`
	`35`	`+ this.name = assertNotNull(name, () -> "Argument name cannot be null");`
`36`	`36`	`this.value = assertNotNull(value, () -> "Argument value cannot be null");`
`37`	`37`	`}`
`38`	`38`
`@@ -99,7 +99,7 @@ public boolean isEqualTo(@Nullable Node o) {`
`99`	`99`
`100`	`100`	`@Override`
`101`	`101`	`public Argument deepCopy() {`
`102`		`- return new Argument(name, assertNotNull(deepCopy(value), "Argument value cannot be null"), getSourceLocation(), getComments(), getIgnoredChars(), getAdditionalData());`
	`102`	`+ return new Argument(assertNotNull(name, "Argument name cannot be null"), assertNotNull(deepCopy(value), "Argument value cannot be null"), getSourceLocation(), getComments(), getIgnoredChars(), getAdditionalData());`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`@Override`