Skip to content

Commit 2d522ed

Browse files
authored
Fix AstPrinter trimming blank string values (#2672)
1 parent 1ee9630 commit 2d522ed

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

src/main/java/graphql/language/AstPrinter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ private String value(Value value) {
482482
} else if (value instanceof FloatValue) {
483483
return valueOf(((FloatValue) value).getValue());
484484
} else if (value instanceof StringValue) {
485-
return wrap("\"", escapeJsonString(((StringValue) value).getValue()), "\"");
485+
return "\"" + escapeJsonString(((StringValue) value).getValue()) + "\"";
486486
} else if (value instanceof EnumValue) {
487487
return valueOf(((EnumValue) value).getName());
488488
} else if (value instanceof BooleanValue) {

src/test/groovy/graphql/language/AstPrinterTest.groovy

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,26 @@ query NullEpisodeQuery {
402402
'''
403403
}
404404

405+
def "ast printing of blank string"() {
406+
def query = '''
407+
query NullEpisodeQuery {
408+
human(id: " ") {
409+
name
410+
}
411+
}
412+
'''
413+
def document = parse(query)
414+
String output = printAst(document)
415+
416+
expect:
417+
output == '''query NullEpisodeQuery {
418+
human(id: " ") {
419+
name
420+
}
421+
}
422+
'''
423+
}
424+
405425
//-------------------------------------------------
406426
def "ast printing of default variables with null"() {
407427
def query = '''

0 commit comments

Comments
 (0)