comment

andimarek · andimarek · commit 2bfd809316bc · 2025-04-03T20:59:57.000+10:00
diff --git a/src/main/java/graphql/execution/ExecutionStrategy.java b/src/main/java/graphql/execution/ExecutionStrategy.java
@@ -486,6 +486,10 @@ private Object fetchField(GraphQLFieldDefinition fieldDef, ExecutionContext exec
         if (fetchedObject instanceof CompletableFuture) {
             @SuppressWarnings("unchecked")
             CompletableFuture<Object> originalFetchValue = (CompletableFuture<Object>) fetchedObject;
+            // the completion order of dependent CFs is in stack order for
+            // directly dependent CFs, but in reverse stack order for indirect dependent ones
+            // By creating one dependent CF on originalFetchValue, we make sure the order it is always
+            // in reverse stack order
             CompletableFuture<Object> fetchedValue = originalFetchValue.thenApply(Function.identity());
             executionContext.incrementRunning(fetchedValue);
             CompletableFuture<Object> rawResultCF = fetchedValue
