Skip to content

Commit 09111ae

Browse files
authored
providing default ExecutionStrategy in GraphQL (#2039)
1 parent 61a78fe commit 09111ae

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

‎src/main/java/graphql/GraphQL.java‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@ public class GraphQL {
8787
private static final Logger logNotSafe = LogKit.getNotPrivacySafeLogger(GraphQL.class);
8888

8989
private final static Instrumentation DEFAULT_INSTRUMENTATION = new DataLoaderDispatcherInstrumentation();
90+
private final static ExecutionStrategy DEFAULT_QUERY_STRATEGY = new AsyncExecutionStrategy();
91+
private final static ExecutionStrategy DEFAULT_MUTATION_STRATEGY = new AsyncSerialExecutionStrategy();
92+
private final static ExecutionStrategy DEFAULT_SUBSCRIPTION_STRATEGY = new SubscriptionExecutionStrategy();
93+
9094

9195
private final GraphQLSchema graphQLSchema;
9296
private final ExecutionStrategy queryStrategy;
@@ -161,9 +165,9 @@ private GraphQL(GraphQLSchema graphQLSchema,
161165
PreparsedDocumentProvider preparsedDocumentProvider,
162166
ValueUnboxer valueUnboxer) {
163167
this.graphQLSchema = assertNotNull(graphQLSchema, () -> "graphQLSchema must be non null");
164-
this.queryStrategy = queryStrategy != null ? queryStrategy : new AsyncExecutionStrategy();
165-
this.mutationStrategy = mutationStrategy != null ? mutationStrategy : new AsyncSerialExecutionStrategy();
166-
this.subscriptionStrategy = subscriptionStrategy != null ? subscriptionStrategy : new SubscriptionExecutionStrategy();
168+
this.queryStrategy = queryStrategy != null ? queryStrategy : DEFAULT_QUERY_STRATEGY;
169+
this.mutationStrategy = mutationStrategy != null ? mutationStrategy : DEFAULT_MUTATION_STRATEGY;
170+
this.subscriptionStrategy = subscriptionStrategy != null ? subscriptionStrategy : DEFAULT_SUBSCRIPTION_STRATEGY;
167171
this.idProvider = assertNotNull(idProvider, () -> "idProvider must be non null");
168172
this.instrumentation = assertNotNull(instrumentation);
169173
this.preparsedDocumentProvider = assertNotNull(preparsedDocumentProvider, () -> "preparsedDocumentProvider must be non null");
@@ -209,9 +213,9 @@ private static <T> T nvl(T obj, T elseObj) {
209213
@PublicApi
210214
public static class Builder {
211215
private GraphQLSchema graphQLSchema;
212-
private ExecutionStrategy queryExecutionStrategy = new AsyncExecutionStrategy();
213-
private ExecutionStrategy mutationExecutionStrategy = new AsyncSerialExecutionStrategy();
214-
private ExecutionStrategy subscriptionExecutionStrategy = new SubscriptionExecutionStrategy();
216+
private ExecutionStrategy queryExecutionStrategy = DEFAULT_QUERY_STRATEGY;
217+
private ExecutionStrategy mutationExecutionStrategy = DEFAULT_MUTATION_STRATEGY;
218+
private ExecutionStrategy subscriptionExecutionStrategy = DEFAULT_SUBSCRIPTION_STRATEGY;
215219
private ExecutionIdProvider idProvider = DEFAULT_EXECUTION_ID_PROVIDER;
216220
private Instrumentation instrumentation = null; // deliberate default here
217221
private PreparsedDocumentProvider preparsedDocumentProvider = NoOpPreparsedDocumentProvider.INSTANCE;

0 commit comments

Comments
 (0)