Skip to content

feat(audits): Notices section for optional recommendations - #76

Merged
enisdenjo merged 7 commits into
mainfrom
recommendations
Apr 12, 2023
Merged

feat(audits): Notices section for optional recommendations#76
enisdenjo merged 7 commits into
mainfrom
recommendations

Conversation

@enisdenjo

@enisdenjo enisdenjo commented Apr 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

In light of graphql/graphql-over-http#241, after #62.

@enisdenjo
enisdenjo marked this pull request as ready for review April 11, 2023 00:53
benjie
benjie previously requested changes Apr 11, 2023
View reviewed changes

@benjie benjie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like it should be ERROR > WARNING > INFO rather than ERROR > INFO > WARNING.

SHOULD assume application/json content-type when accept is missing seems to be using GET even on server that only support POST, so is incorrectly triggering warnings?

@enisdenjo

enisdenjo commented Apr 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Feels like it should be ERROR > WARNING > INFO rather than ERROR > INFO > WARNING.

Actually its INFO > WARNING > ERROR. But yeah, more importance should be given to the top. I'll reorder in a separate PR.

SHOULD assume application/json content-type when accept is missing seems to be using GET even on server that only support POST, so is incorrectly triggering warnings?

Will be fixed with #77.

@enisdenjo
enisdenjo requested a review from benjie April 12, 2023 10:27
@benjie
benjie dismissed their stale review April 12, 2023 11:28

Stale

@enisdenjo enisdenjo mentioned this pull request Apr 12, 2023
Merged
@enisdenjo
enisdenjo merged commit b8bdc71 into main Apr 12, 2023
@enisdenjo
enisdenjo deleted the recommendations branch April 12, 2023 16:39
enisdenjo pushed a commit that referenced this pull request Apr 14, 2023
@semantic-release-bot
chore(release): 🎉 1.18.0 [skip ci]
68a0041 
# [1.18.0](v1.17.1...v1.18.0) (2023-04-14)

### Bug Fixes

* **audits/server:** Avoid auditing non well-formatted GraphQL-over-HTTP requests ([#62](#62)) ([d72e344](d72e344))
* **audits/server:** Prefer using POST ([#77](#77)) ([8cd7dfb](8cd7dfb))
* **handler:** Stringify errors by exposing only the message ([cabf8a9](cabf8a9))

### Features

* **audits:** Notices section for optional recommendations ([#76](#76)) ([b8bdc71](b8bdc71))
* **handler:** Error formatter function ([#78](#78)) ([c0eaeb4](c0eaeb4))
@enisdenjo

enisdenjo commented Apr 14, 2023

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjie benjie Awaiting requested review from benjie

Assignees

No one assigned

Labels

released Has been released and published

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enisdenjo @benjie