Harden residual Cypher unplanned-chain fallback#1476
Merged
Conversation
fd56cbd to
6ef1aaf
Compare
6ef1aaf to
9582b2c
Compare
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1468.
Summary
logical_plan_defer_codemetadata for Cypher logical-planner deferrals.logical_plan is Noneruntime chain fallback to approved defer-code buckets:anonymous_matchnon_top_level_optional_matchmultiple_match_stagesscalar_projection_alias_matchoptional_match_reentrylogical_plan is Nonecompiled programs.CHANGELOG.md.bin/ci_cypher_surface_guard_baseline.jsonfor the intentional compiled-query metadata surface growth (CompiledCypherQuery.logical_plan_defer_code) and the correspondinglowering.pyline-count increase.Audit
graphistry/tests/compute/gfql/**/*.py:string_queries=517,compiled=442,compile_errors=75,deferred_instances=49.multiple_match_stages: 37non_top_level_optional_match: 10anonymous_match: 1scalar_projection_alias_match: 1Validation
python3 -m pytest -q graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py graphistry/tests/compute/gfql/cypher/test_lowering.py::test_logical_plan_route_for_query_defers_unknown_alias_match_shape_by_default graphistry/tests/compute/gfql/cypher/test_lowering.py::test_logical_plan_route_for_query_allows_unknown_alias_match_shape_when_opted_in graphistry/tests/compute/gfql/cypher/test_lowering.py::test_logical_plan_route_for_query_emits_filter_for_where_predicate->46 passed, 4 warnings./bin/ruff.sh graphistry/compute/gfql_unified.py graphistry/compute/gfql/logical_planner.py graphistry/compute/gfql/cypher/lowering.py graphistry/compute/gfql/cypher/reentry/compiletime.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py graphistry/tests/compute/gfql/cypher/test_lowering.py-> green./bin/typecheck.sh->Success: no issues found in 262 source filespython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py graphistry/tests/compute/gfql/test_logical_planner.py -k 'not cudf'->985 passed, 12 skipped, 112 deselected, 55 warningsgit diff --check-> cleanpython3 bin/ci_cypher_surface_guard.py-> green after intentional baseline refreshpython3 -m pytest -q graphistry/tests/compute/gfql/test_runtime_physical_cutover.py->21 passed./bin/ruff.sh graphistry/tests/compute/gfql/test_runtime_physical_cutover.py-> green9582b2c66fd66a4b2383 passed, 22 skipped, 15 xfailed, 102 warnings(/tmp/pygraphistry-1468-dgx/rapids-25.02-gfql.log)2383 passed, 22 skipped, 15 xfailed, 101 warnings(/tmp/pygraphistry-1468-dgx/rapids-26.02-gfql.log)Notes
./bin/test-minimal-lite.shstarts with apython -> python3shim, but local bare-root collection picks up ignoredplans/andtest_env/directories. Scoped tographistry/tests, it reaches the suite but fails on pre-existing local cuDF/no-CUDA-device and UMAP/cuML auto-selection paths (cudaErrorNoDevice). DGX RAPIDS 25.02 + 26.02 full GFQL validation passed.logical_plan_defer_codeavoids runtime dispatch based on message text and makes the remaining fallback audited/explicit.