[WIP][159] Fix non-deterministic ID assignment#192
Closed
phi-dbq wants to merge 3 commits intographframes:masterfrom
Closed
[WIP][159] Fix non-deterministic ID assignment#192phi-dbq wants to merge 3 commits intographframes:masterfrom
phi-dbq wants to merge 3 commits intographframes:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 86.78% 87.15% +0.36%
==========================================
Files 23 23
Lines 757 755 -2
Branches 59 59
==========================================
+ Hits 657 658 +1
+ Misses 100 97 -3
Continue to review full report at Codecov.
|
Member
|
@phi-dbq What about removing the 2.0 shim? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up task from [#189].
It removes
SQLHelpers.zipWithUniqueIdwhich is no longer needed.We will make scalability test and address potential issues.
In the end, we will make a bug-fix release based on changes in this PR.