This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Fix of 826: Allow staff to import manufacturers from excel#998
Draft
badijm wants to merge 1 commit intograndnode:developfrom
Draft
Fix of 826: Allow staff to import manufacturers from excel#998badijm wants to merge 1 commit intograndnode:developfrom
badijm wants to merge 1 commit intograndnode:developfrom
Conversation
Contributor
|
We can see here a very important issue. Currently, if staff user imports manufacturers, they will be assigned to all existing stores. This scenario is unacceptable. |
Contributor
Author
|
Any hints how we can eliminate this problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #826
Issue
Allow staff to import manufacturers from excel
Solution
Remove checking
CurrentCustomer.IsStaff()to allow importBreaking changes
Testing