Skip to content

Chore: Update native histogram hints in prometheus data source #96270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bohandley merged 2 commits into from
Nov 15, 2024
Merged

Chore: Update native histogram hints in prometheus data source #96270

bohandley merged 2 commits into from
Nov 15, 2024

Conversation

@M7mdisk
Copy link
Contributor

@M7mdisk M7mdisk commented Nov 12, 2024 •
edited
Loading

What is this feature?

Update prometheus native histogram hints

Why do we need this feature?
Limit prometheus native histogram hints to what is specified in #96035

Who is this feature for?

users using prometheus data source

Which issue(s) does this PR fix?:

Fixes #96035

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@grafana-pr-automation grafana-pr-automation bot added area/frontend pr/external This PR is from external contributor labels Nov 12, 2024
@M7mdisk M7mdisk marked this pull request as ready for review November 12, 2024 10:21
@M7mdisk M7mdisk requested a review from a team as a code owner November 12, 2024 10:21
@github-actions github-actions bot added this to the 11.4.x milestone Nov 12, 2024
@yangkb09 yangkb09 requested a review from bohandley November 12, 2024 15:44
itsmylife
itsmylife approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@itsmylife itsmylife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🚀

@itsmylife itsmylife changed the title [Prometheus] Update native histogram hints Chore: Update native histogram hints in prometheus data source Nov 15, 2024
@itsmylife itsmylife added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Nov 15, 2024
@itsmylife
Copy link
Contributor

itsmylife commented Nov 15, 2024

@M7mdisk Could you please update the unit test that is failing? Then I think it is good to go.

@M7mdisk
Copy link
Contributor Author

M7mdisk commented Nov 15, 2024

@itsmylife Done!

bohandley
bohandley approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@bohandley bohandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution :)

@bohandley bohandley merged commit 4e3e50b into grafana:main Nov 15, 2024
15 of 16 checks passed
@zserge zserge modified the milestones: 11.4.x, 11.4.1, 11.4.0 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmylife itsmylife itsmylife approved these changes

@bohandley bohandley bohandley approved these changes

Assignees

No one assigned

Labels

area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes pr/external This PR is from external contributor

Projects

None yet

Milestone

11.4.0

Development

Successfully merging this pull request may close these issues.

Prometheus: Update native histogram hints

5 participants

@M7mdisk @CLAassistant @itsmylife @bohandley @zserge