Skip to content

Conversation

@ashharrison90
Copy link
Contributor

What is this feature?

  • removes spreading getToggleButtonProps onto the MultiCombobox suffix
    • this was setting the aria-expanded attribute, which isn't valid on a <div> element
    • we don't spread these in regular Combobox
    • instead, all this stuff is handled by the input
  • passes the input id through to useCombobox in MultiCombobox
  • wraps all the <MultiCombobox> stories in <Field> so the inputs are hooked up to labels
  • reenables the storybook a11y tests for MultiCombobox

Why do we need this feature?

  • better a11y

Who is this feature for?

  • everyone

Which issue(s) does this PR fix?:

For #109450

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added this to the 12.3.x milestone Nov 4, 2025
@ashharrison90 ashharrison90 self-assigned this Nov 4, 2025
@ashharrison90 ashharrison90 requested a review from a team as a code owner November 4, 2025 16:44
@ashharrison90 ashharrison90 added area/grafana/ui Issues that belong to components in the @grafana/ui library no-backport Skip backport of PR labels Nov 4, 2025
@ashharrison90 ashharrison90 requested review from joshhunt and removed request for a team November 4, 2025 16:44
@ashharrison90 ashharrison90 requested a review from samsch November 4, 2025 16:44
@ashharrison90 ashharrison90 added no-changelog Skip including change in changelog/release notes area/accessibility labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/accessibility area/frontend area/grafana/ui Issues that belong to components in the @grafana/ui library no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes

Projects

Status: 🔍 In review

Development

Successfully merging this pull request may close these issues.

1 participant