ConfigFormGithubCollapse: Hide github features section if nothing is available #113410
+163
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…available. Added unit tests
ywzheng1
added
area/frontend
no-changelog
|
/deploy-to-hg |
|
ywzheng1
commented
Nov 4, 2025
| </Field> | ||
| )} | ||
| <Stack direction="column" gap={2}> | ||
| {imageRenderingAllowed && ( |
There was a problem hiding this comment.
no logic changes from here to the end, things changes:
- code moved inside
Stackcomponent - added
noMarginprops toField
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ConfigFormGithubCollapse component to improve its conditional rendering logic and layout structure. The changes introduce early returns for cases where no content should be displayed and wrap fields in a Stack component for consistent spacing.
Key changes:
- Added early return when neither GitHub feature is applicable (image rendering disabled on public instances)
- Wrapped field elements in a
Stackcomponent with consistent vertical spacing - Added comprehensive test coverage for different rendering scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ConfigFormGithubCollapse.tsx | Adds early return logic and wraps fields in Stack component with noMargin props for consistent spacing |
| ConfigFormGithubCollapse.test.tsx | Adds comprehensive test suite covering all rendering scenarios and conditional logic |
| eslint-suppressions.json | Removes no-restricted-syntax suppressions that are no longer needed after refactoring |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
ConfigFormGithubCollapse: Hide whole collapse section if none of feature is available to avoid user confusion.Tested in ephemeral:
Local should still show:
Why do we need this feature?
Avoid user confusion.
Who is this feature for?
Git sync user
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/git-ui-sync-project/issues/641
Special notes for your reviewer:
Please check that: