Alerting: Bug fix for regex matching in Alerts page #113400
Open
+196
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenashleigh
changed the title
laurenashleigh
requested review from
gillesdemey,
konrad147 and
soniaAguilarPeiron
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes regex filters in the Alerts Triage page https://github.com/grafana/alerting-squad/issues/1262. Regex metacharacters in
=~patterns are now preserved instead of being escaped, allowing patterns likefoo.*to work correctly.Root Cause: The default AdHocFiltersVariable expression builder from @grafana/scenes escapes all regex metacharacters for all operators, which breaks user-entered regex patterns.