datasources: apiserver: do not enable extra methods by default #113395
+48
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor
requested review from
owen-d and
stephaniehingtgen
and removed request for
a team
dafydd-t
reviewed
Nov 4, 2025
| }`, string(jj)) | ||
| }) | ||
|
|
||
| t.Run("Call subresources", func(t *testing.T) { |
There was a problem hiding this comment.
Can we add a comment with context for these commented out tests?
There was a problem hiding this comment.
good point, added info 👍
dafydd-t
approved these changes
Nov 4, 2025
gabor
force-pushed
the
gabor/no-new-methods
branch
from
6aec7c5 to
f61babc
Compare
dafydd-t
reviewed
Nov 5, 2025
|
|
||
| func (r *subHealthREST) Connect(ctx context.Context, name string, opts runtime.Object, responder rest.Responder) (http.Handler, error) { | ||
| if !healthEnabled { | ||
| return nil, errors.New("health: endpoint disabled") |
There was a problem hiding this comment.
this is a nit: I prefer the term 'not implemented' as its feels more standardised, like in the 501 HTTP code. As a bonus, could we return 501 here instead of 500?
There was a problem hiding this comment.
I don't think we need the health: prefix on the error message either
dafydd-t
reviewed
Nov 5, 2025
| } | ||
| `, string(body)) | ||
| _, err = client.Get(ctx, "test", metav1.GetOptions{}, "health") | ||
| // endpoint is disabled currently |
There was a problem hiding this comment.
I think we need more context in this comment about why this is disabled
gabor
force-pushed
the
gabor/no-new-methods
branch
from
f61babc to
a4e3eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the extra non-crud apiserver methods (check-health, call-resource, datasource proxy) have not been tested yet, so we will not enable them by default.