Scopes: Nested scope navigations #113394
Draft
Scopes: Nested scope navigations #113394
+895
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskarhed
commented
Nov 4, 2025
Comment on lines
59
to
+60
| // Expand the group that matches the current path, if it is not already expanded | ||
| private onLocationChange = (pathname: string) => { | ||
| private onLocationChange = async (pathname: string) => { |
There was a problem hiding this comment.
We need to verify this functionality and how it handles expanion
tskarhed
commented
Nov 4, 2025
| url: string; | ||
| // Used for testid and keys | ||
| id: string; | ||
| hasSubScope?: boolean; |
There was a problem hiding this comment.
This should not be needed on the status.
tskarhed
commented
Nov 4, 2025
| const isCurrent = isCurrentPath(locPathname, to); | ||
|
|
||
| // Use exchange-alt icon for subScope items | ||
| const iconName = hasSubScope ? 'exchange-alt' : linkIcon; |
There was a problem hiding this comment.
subScope items should be rendered as folders, so no need for this here.
tskarhed
commented
Nov 5, 2025
| const isEmpty = | ||
| Object.keys(currentFolder.folders).length === 0 && Object.keys(currentFolder.suggestedNavigations).length === 0; | ||
|
|
||
| if (isEmpty) { |
There was a problem hiding this comment.
Do an early return instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Why do we need this feature?
To easier move between context
Who is this feature for?
Scopes users
Which issue(s) does this PR fix?:
Closes https://github.com/grafana/hyperion-planning/issues/446
Special notes for your reviewer:
Please check that: