grafana-flamegraph: Add storybook stories for major components #113375
+112
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds storybook stories for the following components:
FlameGraphContainer- High level component that renders the classic Grafana flame graph + top tableFlameGraph- the flame graph portion of the Grafana flame graph vizTopTable- the top table portion of the Grafana flame graph vizWhy do we need this feature?
This should help future developers make changes to the flame graph library without needing to spin up a separate environment (usually by way of a local Grafana + local plugin that imports the dev version of the flame graph package) to test strictly UI changes.
Who is this feature for?
Developers of the flame graph package mostly, but also those who want to use the flame graph viz in plugins.