Datasource: Fix Tempo datasource to enable secure gRPC connection over TLS regardless of Basic auth setting #111770
+13
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR improve the Tempo datasource configuration to enable gRPC over TLS based on the datasource url scheme (http or https) regardless of the auth mechanism.
Why do we need this feature?
It is currently confusing that the toggle to enable gRPC over TLS is based on the presence of the basic auth setting.
Basic auth and TLS serve different purposes, each setting should work independently: basic auth should work regardless of TLS and TLS regardless of basic auth.
Who is this feature for?
Grafana Admin user managing datasources.
Before
Basic auth was required in order for gRPC streaming capabilities to work over TLS
After
No need for basic auth settings anymore in order for gRPC streaming capabilities to work over TLS
Please check that: