Remove dashboardDsAdHocFiltering feature toggle #111706
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dashboardDsAdHocFiltering feature toggle has been enabled by default and is now in General Availability stage. This commit removes the feature toggle and makes the AdHoc filtering functionality for the dashboard datasource permanently available. Changes: - Remove feature toggle from registry.go - Regenerate feature toggle files - Remove conditional checks in frontend code - Update tests to reflect permanent enablement - Always show AdHoc Filters toggle in dashboard query editor - Always enable dashboard datasource in DataSourcePicker for variables
|
Cursor Agent can help with this pull request. Just |
|
|
github-actions
bot
added
area/backend
area/frontend
type/docs
|
💻 Deploy preview available: |
samjewell
requested review from
grafakus and
harisrozajac
and removed request for
a team
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR removes the
dashboardDsAdHocFilteringfeature toggle from the Grafana codebase. The functionality it controlled (AdHoc filtering for the dashboard datasource) is now permanently enabled.Why do we need this feature?
The
dashboardDsAdHocFilteringfeature toggle was already enabled by default (Expression: "true") and had reached General Availability. Its removal simplifies the codebase by eliminating unnecessary conditional logic and feature toggle management overhead.Who is this feature for?
This change is primarily for Grafana developers and maintainers, as it refactors and cleans up the codebase. End-users will experience no change in functionality, as the feature was already active.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: