[WIP] Packages: Use custom conditions for development #111685
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
requested review from
academo,
eledobleefe,
joshhunt and
tomratcliffe
and removed request for
a team
jackw
requested review from
charandas,
gillesdemey,
konrad147,
laurenashleigh,
radiohead and
soniaAguilarPeiron
and removed request for
a team
… of nested file paths
jackw
force-pushed
the
jackw/npm-package-customconditions
branch
from
1a97536 to
98e5017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds the customCondition
@grafana-app/sourceto the repo to allow the frontend tooling to resolve the source files of the packages during development and build without impacting consumers of the packages once published to NPM.Why do we need this feature?
We've been using yarns publishConfig and custom scripts to achieve the same thing. Now there's a legit way to do it via nodejs and tooling I think we should research using that as an alternative to maintaining custom scripts.
Who is this feature for?
Grafana maintainers
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: