Skip to content

Conversation

@ryantxu
Copy link
Contributor

@ryantxu ryantxu commented Sep 24, 2025

This removes the ability to opt-out of a secure client for unified storage

@ryantxu ryantxu added the no-backport Skip backport of PR label Sep 24, 2025
@ryantxu ryantxu requested review from a team and grafanabot as code owners September 24, 2025 09:48
@ryantxu ryantxu added the no-changelog Skip including change in changelog/release notes label Sep 24, 2025
@ryantxu ryantxu requested review from a team as code owners September 24, 2025 09:48
@ryantxu ryantxu requested review from JohnnyQQQQ, ferruvich and konsalex and removed request for a team September 24, 2025 09:48
@github-actions github-actions bot added this to the 12.3.x milestone Sep 24, 2025
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ryantxu ryantxu enabled auto-merge (squash) September 24, 2025 20:55
@ryantxu ryantxu disabled auto-merge September 25, 2025 07:25
@ryantxu ryantxu requested a review from pstibrany September 25, 2025 12:07
@ryantxu
Copy link
Contributor Author

ryantxu commented Sep 25, 2025

@pstibrany -- i could not totally remove the channel based version without somehow wireing up a token service for tests 😬

Is this a good enough improvement? or is the nil secttings.Cfg just too weird?

@grafana-pr-automation grafana-pr-automation bot removed the request for review from grafanabot September 29, 2025 08:27
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good enough improvement? or is the nil secttings.Cfg just too weird?

I think removal of feature toggle is still worth merging.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/backend area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes stale Issue with no recent activity type/feature-toggle-removal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants