[Oauth]Add PKCE option for github(GF_AUTH_GITHUB_USE_PKCE) #111436
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
arukiidou
changed the title
There was a problem hiding this comment.
Thanks for the contribution @arukiidou!
Adding the PKCE option for GitHub OAuth makes sense, especially keeping the default as false for now to avoid breaking anything.
The defaults update and sample.ini changes look straightforward and user-friendly.
From a user perspective, everything seems good. 👍
colin-stuart
requested review from
a team,
cinaglia and
dmihai
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
GitHub OAuth environment option for GitHub OAuth can override defaults using
GF_AUTH_GITHUB_USE_PKCE.Why do we need this feature?
https://github.blog/changelog/2025-07-14-pkce-support-for-oauth-and-github-app-authentication/
Who is this feature for?
Users for using Github Oauth
Which issue(s) does this PR fix?:
Special notes for your reviewer:
To prevent something from breaking for users, we will still keep the default as false.
However, in v13, we should use PKCE by default.
Please check that: