-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Alerting: Check if TimeInterval is used in ActiveTimings when deleting #110691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Please update integration tests too grafana/pkg/tests/apis/alerting/notifications/timeinterval/timeinterval_test.go Lines 766 to 780 in cc869e7
|
|
/deploy-to-hg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
I think this needs to be backported to 12.1.x |
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs Error messagehandling pull request comment event: running grafana-build deb: executing command: stdout= stderr=go: downloading github.com/urfave/cli/v2 v2.27.7 exit status 1 |
1b24553 to
a662115
Compare
a662115 to
095e50c
Compare
|
/deploy-to-hg |
|
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs Error messagehandling pull request comment event: running grafana-build deb: executing command: stdout= stderr=go: downloading github.com/urfave/cli/v2 v2.27.7 exit status 1 |
A bug was found where it was possible to delete a
TimeIntervalthat was in use as anActiveTiming- this would then lead to a persistent error that the Alertmanager config was corrupted. This PR updatesisTimeIntervalInUseInRoutesto checkActiveTimingsalso.Please check that: