Skip to content

Conversation

@soniaAguilarPeiron
Copy link
Contributor

What is this feature?

This PR moves alerting.ts from public/app/types/ to public/app/features/alerting/unified/types/
and update all 32 import statements to use the new location. This consolidates
alerting-related types within the unified alerting feature structure.

Why do we need this feature?

It's a refactor.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added this to the 12.2.x milestone Aug 28, 2025
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this Aug 28, 2025
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner August 28, 2025 06:55
@soniaAguilarPeiron soniaAguilarPeiron added the area/alerting Grafana Alerting label Aug 28, 2025
@soniaAguilarPeiron soniaAguilarPeiron requested review from gillesdemey, konrad147 and laurenashleigh and removed request for a team August 28, 2025 06:55
@soniaAguilarPeiron soniaAguilarPeiron added the no-backport Skip backport of PR label Aug 28, 2025
@github-project-automation github-project-automation bot moved this to In review in Alerting Aug 28, 2025
Copy link
Contributor

@gillesdemey gillesdemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

@soniaAguilarPeiron soniaAguilarPeiron enabled auto-merge (squash) August 28, 2025 11:48
@soniaAguilarPeiron soniaAguilarPeiron merged commit 58e649a into main Aug 28, 2025
101 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the alerting/move-alerting-file branch August 28, 2025 12:11
@github-project-automation github-project-automation bot moved this from In review to Done in Alerting Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants