Skip to content

[release-12.1.2] Chore: Don't show a "Not found" for public-dashboard fetches if the service is disabled via config #110144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

[release-12.1.2] Chore: Don't show a "Not found" for public-dashboard fetches if the service is disabled via config #110144

merged 1 commit into from
Aug 26, 2025

Conversation

@Proximyst
Copy link
Member

@Proximyst Proximyst commented Aug 26, 2025 •
edited
Loading

This backports #108650 to Grafana 12.1.3. (Yes, the title disagrees; our branch naming is weird.)

Fixes: #108732
Fixes: https://github.com/grafana/support-escalations/issues/18035

@mmandrus @Proximyst
Chore: Don't show a "Not found" for public-dashboard fetches if the s…
d889726 
…ervice is disabled via config (#108650)

don't show 404 toast if pubdash is completely disabled

(cherry picked from commit f69f25b)
@Proximyst Proximyst self-assigned this Aug 26, 2025
@Proximyst Proximyst added add to changelog no-backport Skip backport of PR backport A backport PR labels Aug 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025

😢 zizmor failed with exit code 14.

Expand for full output 
error[bot-conditions]: spoofable bot actor check
  --> ./.github/workflows/pr-dependabot-update-go-workspace.yml:18:3
   |
18 | /   update:
19 | |     runs-on: "ubuntu-latest"
20 | |     if: ${{ github.actor == 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository }}
   | |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ actor context may be spoofable
21 | |     continue-on-error: true
...  |
68 | |           git push origin "$BRANCH_NAME"
69 | |         fi
   | |___________^ this job
   |
   = note: audit confidence → Medium
   = note: this finding has an auto-fix

192 findings (63 ignored, 128 suppressed, 1 fixable): 0 unknown, 0 informational, 0 low, 0 medium, 1 high

@Proximyst Proximyst marked this pull request as ready for review August 26, 2025 09:05
@Proximyst Proximyst requested a review from a team as a code owner August 26, 2025 09:05
@Proximyst Proximyst requested review from a team, harisrozajac and oscarkilhed and removed request for a team August 26, 2025 09:05
@Proximyst Proximyst merged commit e5b4036 into release-12.1.2 Aug 26, 2025
96 of 98 checks passed
@Proximyst Proximyst deleted the mariell/backport-108650 branch August 26, 2025 10:58
@Proximyst Proximyst mentioned this pull request Aug 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macabu macabu macabu approved these changes

@dana-axinte dana-axinte dana-axinte approved these changes

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed oscarkilhed is a code owner automatically assigned from grafana/dashboards-squad

@harisrozajac harisrozajac Awaiting requested review from harisrozajac harisrozajac is a code owner automatically assigned from grafana/dashboards-squad

Assignees

@Proximyst Proximyst

Labels

add to changelog area/frontend backport A backport PR no-backport Skip backport of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Proximyst @macabu @dana-axinte @mmandrus