Alerting: Add keepFiringFor and missing_series_evals_to_resolve to file provisioning #109699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ExecErrState *ExecutionErrorState `json:"execErrState,omitempty" yaml:"execErrState,omitempty" hcl:"exec_err_state"` | ||
| For model.Duration `json:"for,omitempty" yaml:"for,omitempty"` | ||
| KeepFiringFor model.Duration `json:"keepFiringFor,omitempty" yaml:"keepFiringFor,omitempty" hcl:"keep_firing_for"` | ||
| KeepFiringFor model.Duration `json:"keepFiringFor,omitempty" yaml:"keepFiringFor,omitempty"` |
There was a problem hiding this comment.
Removed hcl since it shouldn't be here and instead is set below in the special KeepFiringForString field.
| ExecErrState values.StringValue `json:"execErrState" yaml:"execErrState"` | ||
| For values.StringValue `json:"for" yaml:"for"` | ||
| KeepFiringFor values.StringValue `json:"keepFiringFor" yaml:"keepFiringFor"` | ||
| MissingSeriesEvalsToResolve values.Int64Value `json:"missing_series_evals_to_resolve" yaml:"missing_series_evals_to_resolve"` |
There was a problem hiding this comment.
Added MissingSeriesEvalsToResolve and KeepFiringFor
alexander-akhmetov
force-pushed
the
alexander-akhmetov/keep-firing-for-file-provisioning
branch
from
3dfba62 to
e4d94c2
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/keep-firing-for-file-provisioning
branch
from
e4d94c2 to
0195b32
Compare
rwwiv
approved these changes
Aug 14, 2025
alexander-akhmetov
deleted the
alexander-akhmetov/keep-firing-for-file-provisioning
branch
alexander-akhmetov
added a commit
that referenced
this pull request
Aug 14, 2025
…le provisioning (#109699)
alexander-akhmetov
added a commit
that referenced
this pull request
Aug 14, 2025
…le provisioning (#109699)
gillesdemey
pushed a commit
that referenced
this pull request
Aug 18, 2025
…le provisioning (#109699)
alexander-akhmetov
added
backport v12.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Added support for
keepFiringForandmissing_series_evals_to_resolvefields in alert rule file provisioning.Why do we need this feature?
These fields were being ignored in file provisioning despite being supported in the API.
Who is this feature for?
Users of file provisioning in Grafana Alerting.
Which issue(s) does this PR fix?:
Fixes #109367
Special notes for your reviewer:
Please check that: