Dashboard: Inspect drawer can no longer be opened with url or linked to #109617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
mdvictor and
oscarkilhed
and removed request for
a team
torkelo
force-pushed
the
remove-inspect-url-sync
branch
from
d1c89f1 to
44b0bb5
Compare
torkelo
changed the title
torkelo
requested review from
bfmatei,
dprokop and
thanos-karachalios
and removed request for
mdvictor
oscarkilhed
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
I agree with this change.
It also got me thinking about if we really need url sync support for share and export. They are also side panes that open where I don't think there is a lot of benefit of linking to.
Keeping them in the url sync isn't as complex. But It is a bit inconsistent. I also think it's a bit weird that the opening of those side panels get added to the browser history. So navigating back opens the closed side pane.
Since we don't have the edit mode in the url sync you can get into a weird state. You can't enter into export / share without first exiting edit mode. But if you open the panel, enter into edit mode and navigate back, you will have the panel open but also be in edit mode.
torkelo
requested review from
eledobleefe and
joshhunt
and removed request for
a team
gillesdemey
pushed a commit
that referenced
this pull request
Aug 18, 2025
…to (#109617) * Inspect: Remove url state support * Fixes * fix e2e * fix lint * fix lint * fix test * Update
gelicia
pushed a commit
that referenced
this pull request
Aug 19, 2025
…to (#109617) * Inspect: Remove url state support * Fixes * fix e2e * fix lint * fix lint * fix test * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The url state support for the inspect drawer is buggy (as it does not work with lazy loading), and just adds a lot of unnessary complexity.
I think we can remove it / should remove it