Alerting: Auto refresh contact points in the rule form #109539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad147
added
area/alerting
|
/deploy-to-hg |
|
|
konrad147
changed the title
konrad147
requested review from
gillesdemey,
laurenashleigh and
soniaAguilarPeiron
and removed request for
a team
|
/deploy-to-hg |
|
|
nit: prefer the first arg to the hook to be an empty object or something. Maybe later we will add some config option we want to support and I'd like the hook behaviour options to be somewhat separate from that. |
|
|
/deploy-to-hg |
|
|
gillesdemey
pushed a commit
that referenced
this pull request
Aug 18, 2025
gelicia
pushed a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the behavior and flexibility of the contact point selection component by allowing more control over how and when contact point data is refreshed. The main changes include adding support for passing query options to the contact points fetching hook and updating the selector component to use these options for better data freshness.
Contact point data fetching improvements:
refetchOnFocusandrefetchOnMountOrArgChange) to theuseListContactPointshook, allowing callers to control data refetching behavior.ContactPointSelectorto use the new query options, ensuring the contact points list stays up-to-date when the component mounts or the window regains focus.