-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Actions: Infinity authentication #109493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions: Infinity authentication #109493
Conversation
|
/deploy-to-hg |
|
|
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs Error messagehandling pull request comment event: running grafana-build deb: executing command: stdout= stderr=go: downloading dagger.io/dagger v0.18.8 exit status 1 |
|
/deploy-to-hg |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- this is a good way to get this feature usable while we figure out a less awkward backend proxy approach.
|
/deploy-to-hg |
|
|
|
/deploy-to-hg |
|
| data, | ||
| headers: requestHeaders, | ||
| params: requestQueryParams, | ||
| body_type: 'raw', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I assume that the remaining body_types will be supported later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't really understand how body_type differs or relates to body_content_type, which kinda-sorta maps to content-type headers? except it's a bit odd that body_content_type list does not include the web standard application/x-www-form-urlencoded 🤷
is there something that the other body_type options offer that is not covered by our current options with raw? 🤔
|
This PR introduces authenticated HTTP requests for viz actions by integrating with the Infinity datasource. Users can now perform actions that require authentication (Basic Auth, Digest Auth, API keys, etc.) by leveraging pre-configured Infinity datasource connections.
Viewers cannot see/execute actions.
Infinity set up for basic authentication:
Test endpoints:
Authenticated requests via actions:
actions.auth.with.infinity.mov
Test dashboard:
TS - Actions w/ Infinity auth
TODO:
Please check that: