Nested folders: Remove feature flag #109212
Merged
+494
−1,084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/alerting
|
💻 Deploy preview deleted. |
stephaniehingtgen
force-pushed
the
nested-folders-remove-ff
branch
from
d4adbbb to
47b4336
Compare
stephaniehingtgen
requested review from
alexanderzobnin,
joshhunt,
mohammad-hamid,
owensmallwood and
samsch
and removed request for
a team
stephaniehingtgen
requested review from
a team,
inf0rmer and
ryantxu
and removed request for
a team,
alexanderzobnin,
gillesdemey,
joshhunt,
konrad147,
laurenashleigh,
mohammad-hamid,
owensmallwood,
radiohead,
samsch and
soniaAguilarPeiron
stephaniehingtgen
force-pushed
the
nested-folders-remove-ff
branch
from
8223c40 to
38618fb
Compare
Comment on lines
+903
to
+905
| if item.FolderTitle != "" { | ||
| item.FolderSlug = slugify.Slugify(item.FolderTitle) | ||
| } |
There was a problem hiding this comment.
why this block? I don't see how this is related to the removal of NestedFolders flag
There was a problem hiding this comment.
it has always been incorrect :( the unit test just didn't catch it because the feature flag was disabled:
https://github.com/grafana/grafana/pull/109212/files/38618fb191a51e4941ed3b91e60fc96f2b9d1e0d#diff-905cf7e02756f63788adbfc506a763d293d2ecaedeee27287b2d5ac65f9bf351L75
| await user.type(await ui.inputs.name.find(), 'my great new rule'); | ||
| await user.click(await screen.findByRole('button', { name: /select folder/i })); | ||
| await user.click(await screen.findByLabelText(/folder a/i)); | ||
| await user.click(await screen.findByLabelText('Folder A')); |
There was a problem hiding this comment.
This is currently the functionality when running main
There was a problem hiding this comment.
I was going to ask about that 😅 Thank you for the clarification
filewalkwithme
approved these changes
Aug 5, 2025
ryantxu
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR removes the nestedFolders feature toggle, which was introduced in Grafana 10 and enabled by default in Grafana 11