-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Chore: Remove prometheusCodeModeMetricNamesSearch feature toggle #109024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
itsmylife
merged 8 commits into
main
from
ismail/remove-prometheusCodeModeMetricNamesSearch-2
Aug 27, 2025
Merged
Chore: Remove prometheusCodeModeMetricNamesSearch feature toggle #109024
itsmylife
merged 8 commits into
main
from
ismail/remove-prometheusCodeModeMetricNamesSearch-2
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana-prometheusRemovalsPrometheusDatasource.metricNamesAutocompleteSuggestionLimit/home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/datasource.d.ts metricNamesAutocompleteSuggestionLimit: number;PromOptions.codeModeMetricNamesSuggestionLimit /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/types.d.ts codeModeMetricNamesSuggestionLimit?: number;
|
jackw
reviewed
Aug 1, 2025
zoltanbedi
approved these changes
Aug 27, 2025
…earch-2 # Conflicts: # packages/grafana-prometheus/src/components/monaco-query-field/monaco-completion-provider/monaco-completion-provider.ts # packages/grafana-prometheus/src/datasource.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend
area/frontend
datasource/Prometheus
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
no-backport
Skip backport of PR
type/chore
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When we have this (#108341) in place we won't be needed this feature toggle.
All code and components related to this feature toggle is deleted with this PR