Flame Graph: Analyze with Grafana Assistant #108684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifrost
changed the title
github-actions
bot
added
area/frontend
datasource/grafana-pyroscope
Good call - we can change that! Great job in the integration. |
svennergr
reviewed
Jul 28, 2025
|
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs |
|
/deploy-to-hg |
|
|
github-actions
bot
added
the
type/docs
|
💻 Deploy preview deleted. |
|
/deploy-to-hg |
|
|
|
/deploy-to-hg |
|
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs |
|
What's going on with the deploys @ifrost? Seems like half the time it fails and the other half it only lasts for less than a day or something? |
|
/deploy-to-hg |
|
|
Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs |
|
/deploy-to-hg |
|
|
Seems like a mix of not being synced with main and some issue in dev environment. The ephemeral is up and running now. I needed it double check flame graph load fine. It incorrectly shows the button for non-pyroscope queries so I need to double check it 🤔 |
gelicia
pushed a commit
that referenced
this pull request
Aug 19, 2025
* Bare-bones mocked integration * Create correct context based on the query * Add data source name * Do not bundle grafana/assistant with flame graph * Rename component * Add tests * Mock grafana/assistant * Update feature toggle and allow hiding the button * Update deps * Update types * Update yarn.lock * Fix typo in feature toggle description * Enable grafanaAssistantInProfilesDrilldown by default * Enable grafanaAssistantInProfilesDrilldown by default * Show Analyze Flame Graph button only if there's context for the assistant
leeoniya
pushed a commit
that referenced
this pull request
Aug 19, 2025
* Bare-bones mocked integration * Create correct context based on the query * Add data source name * Do not bundle grafana/assistant with flame graph * Rename component * Add tests * Mock grafana/assistant * Update feature toggle and allow hiding the button * Update deps * Update types * Update yarn.lock * Fix typo in feature toggle description * Enable grafanaAssistantInProfilesDrilldown by default * Enable grafanaAssistantInProfilesDrilldown by default * Show Analyze Flame Graph button only if there's context for the assistant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #108773
Integrates Flame Graph package with Grafana Assistant.
Important notes:
grafana/assistantbecomes a peerDependency, meaning anyone consuming new version ofgrafana/flamegraphwould need to install it (we can make it optional peerDependency and load it dynamically, but not sure if it's worth it)grafana/flamegraph(Profiles Drilldown don't use core Flamegraph but includes its own) + feat(AI): Integrate with Grafana Assistant profiles-drilldown#558getObservablePluginLinkswhich fails if Grafana is not loadedChatItemContext(see also https://github.com/grafana/grafana-assistant-app/pull/1035)Here's how it works:
Screen.Recording.2025-07-25.at.14.15.46.mov