Skip to content

Conversation

@grafana-delivery-bot
Copy link
Contributor

Backport a421f55 from #107993


A bug was introduced in #99055 that sets the default mode for Log Analytics queries to builder. This is actually invalid for two reasons:

  1. It can break existing queries (it hasn't yet but in theory it could).
  2. It prevents switching the time management field between query and dashboard as query is disabled for the builder.

I've also added tests for this case.

Fixes #106555

* Fix mode setting

* Update selector

* Add tests

* Fix condition

(cherry picked from commit a421f55)
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@grafana-delivery-bot grafana-delivery-bot bot changed the base branch from release-12.0.3 to release-12.0.4 July 23, 2025 19:35
@grafana-delivery-bot
Copy link
Contributor Author

Hello @grafana-delivery-bot[bot], we've noticed that the original base branch release-12.0.3 for this PR is no longer a release candidate. We've automatically updated your PR's base branch to the current release target: release-12.0.4. Please review and resolve any potential merge conflicts. If this PR is not merged it will NOT be included in the next release. Thanks!

@github-actions

This comment has been minimized.

@grafana-delivery-bot grafana-delivery-bot bot changed the base branch from release-12.0.4 to release-12.0.5 August 13, 2025 15:18
@grafana-delivery-bot
Copy link
Contributor Author

Hello @grafana-delivery-bot[bot], we've noticed that the original base branch release-12.0.4 for this PR is no longer a release candidate. We've automatically updated your PR's base branch to the current release target: release-12.0.5. Please review and resolve any potential merge conflicts. If this PR is not merged it will NOT be included in the next release. Thanks!

@github-actions
Copy link
Contributor

😢 zizmor failed with exit code 14.

Expand for full output
error[cache-poisoning]: runtime artifacts potentially vulnerable to a cache poisoning attack
  --> ./.github/workflows/backend-code-checks.yml:3:1
   |
 3 | / on:
 4 | |   pull_request:
...  |
15 | |       - 'docs/**'
16 | |       - 'latest.json'
   | |_____________________^ generally used when publishing artifacts generated at runtime
17 |
...
31 |           uses: actions/setup-go@v5
32 | /         with:
33 | |           # Explicitly set Go version to 1.24.1 to ensure consistent OpenAPI spec generation
...  |
36 | |           go-version: 1.24.1
37 | |           cache: true
   | |_____________________^ opt-in for caching here
   |
   = note: audit confidence → Low

error[cache-poisoning]: runtime artifacts potentially vulnerable to a cache poisoning attack
  --> ./.github/workflows/go-lint.yml:2:1
   |
 2 | / on:
 3 | |   push:
...  |
10 | |       - release-*.*.*
11 | |   pull_request:
   | |_______________^ generally used when publishing artifacts generated at runtime
12 |
...
22 |             persist-credentials: false
23 |         - uses: actions/setup-go@v5
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^ cache enabled by default here
   |
   = note: audit confidence → Low

error[bot-conditions]: spoofable bot actor check
  --> ./.github/workflows/pr-dependabot-update-go-workspace.yml:18:3
   |
18 | /   update:
19 | |     runs-on: "ubuntu-latest"
20 | |     if: ${{ github.actor == 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository }}
   | |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ actor context may be spoofable
21 | |     continue-on-error: true
...  |
68 | |           git push origin "$BRANCH_NAME"
69 | |         fi
   | |___________^ this job
   |
   = note: audit confidence → Medium
   = note: this finding has an auto-fix

error[cache-poisoning]: runtime artifacts potentially vulnerable to a cache poisoning attack
  --> ./.github/workflows/run-schema-v2-e2e.yml:3:1
   |
 3 | / on:
 4 | |   push:
...  |
 9 | |     branches:
10 | |       - '**'
   | |____________^ generally used when publishing artifacts generated at runtime
11 |
...
25 |         - name: Pin Go version to mod file
26 |           uses: actions/setup-go@v5
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^ cache enabled by default here
   |
   = note: audit confidence → Low

error[cache-poisoning]: runtime artifacts potentially vulnerable to a cache poisoning attack
  --> ./.github/workflows/run-schema-v2-e2e.yml:3:1
   |
 3 | / on:
 4 | |   push:
...  |
 9 | |     branches:
10 | |       - '**'
   | |____________^ generally used when publishing artifacts generated at runtime
11 |
...
30 |         - uses: actions/setup-node@v4
31 | /         with:
32 | |           node-version-file: '.nvmrc'
33 | |           cache: 'yarn'
   | |_______________________^ opt-in for caching here
   |
   = note: audit confidence → Low

201 findings (64 ignored, 132 suppressed, 1 fixable): 0 unknown, 0 informational, 0 low, 0 medium, 5 high

@aangelisc aangelisc merged commit 5195a6d into release-12.0.5 Aug 18, 2025
83 of 85 checks passed
@aangelisc aangelisc deleted the backport-107993-to-release-12.0.3 branch August 18, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant