Skip to content

Add GPUBuffer in GPUBindingResource#5193

Merged
kainino0x merged 6 commits intogpuweb:mainfrom
beaufortfrancois:buffer-binding-resource
May 22, 2025
Merged

Add GPUBuffer in GPUBindingResource#5193
kainino0x merged 6 commits intogpuweb:mainfrom
beaufortfrancois:buffer-binding-resource

Conversation

@beaufortfrancois
Copy link
Contributor

FIX #5095

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

Previews, as seen when this build job started (865c9b3):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@kainino0x kainino0x added api resolved Resolved - waiting for a change to the API specification api WebGPU API labels May 22, 2025
@kainino0x kainino0x added this to the Milestone 1 milestone May 22, 2025
Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the review delay!

@beaufortfrancois
Copy link
Contributor Author

@kainino0x Thanks for the review! I've applied your suggestion in latest commit.

@kainino0x kainino0x merged commit 137f7e3 into gpuweb:main May 22, 2025
4 checks passed
@kainino0x kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label May 22, 2025
kainino0x pushed a commit to gpuweb/types that referenced this pull request May 28, 2025
This PR reflects changes from the following spec PRs:
* gpuweb/gpuweb#5193
* gpuweb/gpuweb#5160

Please publish new version after it's merged so that we can add tests in
the CTS as in gpuweb/cts#4390
dneto0 pushed a commit that referenced this pull request Jul 3, 2025
This PR adds GPUTexture support to the following attributes: 
- GPUBindingResource
- GPURenderPassColorAttachment view
- GPURenderPassColorAttachment resolveTarget
- GPURenderPassDepthStencilAttachment view

It also updates parts of the WebGPU and WGSL specs that I've missed when
adding GPUBuffer in GPUBindingResource with
#5193

FIX #5215

---------

Co-authored-by: Kai Ninomiya <kainino@chromium.org>
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 17, 2025
…` r=#webgpu-reviewers!

This change to upstream IDL happened at [gpuweb#5193](gpuweb/gpuweb#5193).  Test coverage was added in [gpuweb/cts#4390](gpuweb/cts#4390).

Differential Revision: https://phabricator.services.mozilla.com/D257634
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Jul 17, 2025
…` r=webgpu-reviewers,webidl,teoxoy,emilio

This change to upstream IDL happened at [gpuweb#5193](gpuweb/gpuweb#5193).  Test coverage was added in [gpuweb/cts#4390](gpuweb/cts#4390).

Differential Revision: https://phabricator.services.mozilla.com/D257634
Chainsawkitten added a commit to Chainsawkitten/WebGPUReconstruct that referenced this pull request Aug 4, 2025
gpuweb/gpuweb#5193 allows using GPUBuffer as a GPUBindingResource. This previously had to be done using a GPUBufferBinding.
Chainsawkitten added a commit to Chainsawkitten/WebGPUReconstruct that referenced this pull request Aug 4, 2025
gpuweb/gpuweb#5193 allows using GPUBuffer as a GPUBindingResource. This previously had to be done using a GPUBufferBinding.
juj added a commit to juj/wasm_webgpu that referenced this pull request Sep 12, 2025
This is a no-op, since wgpuReadBindGroupLayoutDescriptor() operates a statically in Wasm -> JS bindings.
beaufortfrancois added a commit to webgpu/webgpu-samples that referenced this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api resolved Resolved - waiting for a change to the API specification api WebGPU API needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Support GPUBuffer in GPUBindingResource

2 participants