Reformat builtins table #5092
Open
Reformat builtins table #5092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the builtins by stage and input/output as it's arguably less confusiung. Note: This only separates the table. It would be nice to also separate the documentation so that vertex position links to a different place than fragment position and sample_mask input links to different place than sample_mask output. That change can happen in another PR. Issue gpuweb#5081 Note: Other GPU API specs no not combine inputs and outputs from multiple stages into one. * [GLSL](https://registry.khronos.org/OpenGL/specs/es/3.1/GLSL_ES_Specification_3.10.withchanges.pdf), sections (7.1.1, 7.1.2, 7.1.3). * [HLSL](https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-semantics) * [MSL](https://developer.apple.com/metal/Metal-Shading-Language-Specification.pdf) sections 5.2.3.1, 5.2.3.3, 5.2.3.4, 5.2.3.5, 5.2.3.6
|
Previews, as seen when this build job started (95075a6): |
|
The styling of the spec doesn't really draw the eye to table names (in light mode at least) and that's the only place the stage and direction are listed. I'm not opposed to finding a better organization, but I think this can be improved. |
kainino0x
added
wgsl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the builtins by stage and input/output as it's arguably less confusiung.
Note: This only separates the table. It would be nice to also separate the documentation so that vertex position links to a different place than fragment position and sample_mask input links to different place than sample_mask output. That change can happen in another PR.
Issue #5081
Note: Other GPU API specs do not combine inputs and outputs from multiple stages into one.
GLSL sections 7.1.1, 7.1.2, 7.1.3
HLSL
MSL sections 5.2.3.1, 5.2.3.3, 5.2.3.4, 5.2.3.5, 5.2.3.6
Result: