Add 16-bit normalized texture format feature#4938
Closed
beaufortfrancois wants to merge 4 commits intomainfrom
Closed
Add 16-bit normalized texture format feature#4938beaufortfrancois wants to merge 4 commits intomainfrom
beaufortfrancois wants to merge 4 commits intomainfrom
Conversation
Contributor
|
Previews, as seen when this build job started (19aaf47): |
beaufortfrancois
force-pushed
the
16bit-norm-textures
branch
from
20966ef to
9711010
Compare
Contributor
|
the |
Contributor
Author
|
I forced-pushed which caused the preview to not be updated: https://github.com/gpuweb/gpuweb/pull/4938/files#diff-40cc3a1ba233cc3ca7b6d5873260da9676f6ae20bb897b62f7871c80d0bda4e9R5005 |
Contributor
|
The preview should update even on force push. The problem is the build failed:
|
beaufortfrancois
force-pushed
the
16bit-norm-textures
branch
from
77274c9 to
19aaf47
Compare
Contributor
Author
Thanks for catching this! I've fixed it (for real now) |
Contributor
Author
|
My understanding is that #5160 covers it so it can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Issue: #3001