GPUBGLBinding: rename multisample to multisampled.#367
Conversation
|
Possible out of scope for this review, but I'm a bit confused about when an app should specify "true" for this field. Is this a promise about what the properties of the sampler that the shader might use to read from the texture? (Otherwise the actual change itself looks good to me.) |
|
@damyanp this is a promise that the shader sees this texture as an MSAA texture, and we are only able to create bind groups that have a multisampled texture filling this binding. |
|
@kvark - ah, I think I'm catching up. Presumably this would be validated (in all implementations) so that if you try and bind a multisampled texture to a binding where the layout doesn't have this set then it would fail? |
|
Yes, it should be validated along all the other fields of the bind group layout (by all implementations). |
This is because reading binding.multisampled = false seems like better grammar than binding.multisample.
|
Rebased over #365 |
|
Merging this as it is quite trivial. |
This is because reading binding.multisampled = false seems like better
grammar than binding.multisample.
Preview | Diff