Merged
Conversation
kdashg
approved these changes
Jul 12, 2019
| }; | ||
|
|
||
| interface GPUTexture : GPUObjectBase { | ||
| GPUTextureView createView(GPUTextureViewDescriptor desc); |
Contributor
There was a problem hiding this comment.
Descriptors are everywhere here so I think abbreviating to desc is reasonable.
Contributor
There was a problem hiding this comment.
I think this was for consistency with all the GPUDevice methods that take descriptors and call them descriptor.
Contributor
Author
There was a problem hiding this comment.
Yup. Just for consistency, I don't actually care about the name.
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…me validation (gpuweb#364) * From HackMD: manual, stress, web_platform, and documentation * and a few validation tests (the "weird" ones) * address comments * add "TODO:" to description for unimplemented tests * restructure state tests, add error monad test dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff