Rename GPUPipelineStageDescriptor to GPUProgrammableStageDescriptor#359
Merged
kdashg merged 1 commit intogpuweb:masterfrom Jul 15, 2019
Merged
Rename GPUPipelineStageDescriptor to GPUProgrammableStageDescriptor#359kdashg merged 1 commit intogpuweb:masterfrom
kdashg merged 1 commit intogpuweb:masterfrom
Conversation
|
As a developer, I'd expect to see the word "shader" in there somewhere.
|
The important part is that these stages are programmable since they old a shader module. There are other pipeline stages like rasterization that aren't programmable and use a different descriptor.
Contributor
|
Rebased over #365. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 7, 2019
This is to match the WebGPU's WebIDL[1]. [1] gpuweb/gpuweb#359 Bug: 877147 Change-Id: Ia5fedae01348411f5e1c59faebe5c13a3dd85f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843791 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#703362}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The important part is that these stages are programmable since they hold
a shader module. There are other pipeline stages like rasterization that
aren't programmable and use a different descriptor.
Preview | Diff