Rename single element vertex formats to remove the x1 postfix#1469
Merged
Rename single element vertex formats to remove the x1 postfix#1469
Conversation
kainino0x
approved these changes
Feb 24, 2021
Contributor
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
as always I still slightly prefer the x1, but I think this is the way the overall group wants to go.
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Feb 27, 2021
1235: Update VertexFormat variants r=grovesNL a=kvark **Connections** Matches gpuweb/gpuweb#1322 and gpuweb/gpuweb#1469 **Description** Just updates us to recent upstream API. Also breaks lots of user code! **Testing** Not functional Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Kangz
added a commit
to Kangz/types
that referenced
this pull request
Mar 4, 2021
This does the changes to follow: - gpuweb/gpuweb#1322 and - gpuweb/gpuweb#1469
kainino0x
pushed a commit
to gpuweb/types
that referenced
this pull request
Mar 5, 2021
This does the changes to follow: - gpuweb/gpuweb#1322 and - gpuweb/gpuweb#1469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1434
Not sure if that issue needs any further discussion, since it seems like the general sentiment is pretty clear. In any case, here's a button to click when we decide it's time to pull the trigger ⬇
Preview | Diff